[Stats] Add Geometric mean & Harmonic mean#4
Merged
forfudan merged 6 commits intomojomath:mainfrom Mar 7, 2026
Merged
Conversation
1. `True if len(weights) > 0 else False` -> `len(weights) > 0` 2. "Geoemtric" -> "Geometric"
forfudan
approved these changes
Mar 7, 2026
Member
|
Some fixes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for Geometric & Harmonic mean along with tests coverage for these implementations.
Note:
At present, weights must be passed as an empty list
([])rather than None or no argument. This is due to a Mojo limitation (iirc resolved in the latest nightly builds) where Optional[List[T]] cannot be passed as a read argument because List does not conform to ImplicitlyCopyable.An alternative design would be to define
gmeanas:However, this would require explicitly constructing an Optional[List[Float64]] at the call site:
For now, we can standardize on using either one of the possibilities and revisit this in future when mojo let's us pass the List[Float64] such that we can do the following,